Skip to content

[JENKINS-54514] Document error handling in the 'parallel' step #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[JENKINS-54514] Document error handling in the 'parallel' step #260

wants to merge 2 commits into from

Conversation

@ringerc
Copy link
Contributor

@ringerc ringerc commented Nov 7, 2018 •
edited by jglick
Loading

@jglick jglick changed the title Document error handling in the 'parallel' step [JENKINS-54514] Document error handling in the 'parallel' step Nov 7, 2018
@ringerc
Copy link
Contributor Author

ringerc commented Nov 7, 2018

The checks failed due to what appears to be network issues with the Windows builder.

jglick
jglick approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bitwiseman
Copy link
Contributor

bitwiseman commented Jun 14, 2019

@ringerc What do you think of the suggestions?

@ringerc
Copy link
Contributor Author

ringerc commented Jun 15, 2019 via email

@bitwiseman
Copy link
Contributor

bitwiseman commented Oct 26, 2019

@ringerc Any update here? I'd apply the commits myself but I don't have permissions. I'd like to be able to merge this change.

@nickoe
Copy link

nickoe commented Jun 18, 2020

@ringerc @bitwiseman It looks like this has been lost in time.

dwnusbaum
dwnusbaum requested changes Jun 18, 2020
View reviewed changes
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. It would be great to also apply Jesse's comments/suggestions.

src/main/resources/org/jenkinsci/plugins/workflow/cps/steps/ParallelStep/help.html
<code>Throwable.addSuppresssed(...)</code>.
</p>
<p>
Note that a <code>hudson.AbortException</code>, as thrown by failing
Copy link
Member

@dwnusbaum dwnusbaum Dec 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AbortException is not necessarily thrown by failing steps.

I think mentioning AbortException is misleading since it doesn't have any special interaction with the parallel step.

src/main/resources/org/jenkinsci/plugins/workflow/cps/steps/ParallelStep/help.html Outdated
the first failed script.
</p>
<p>
Note: Branch closures should just return <code>null</code>. The return
Copy link
Member

@dwnusbaum dwnusbaum Dec 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this paragraph above the preceding one, and reword it slightly. Since we don't want anyone to rely on the current behavior I think it is best not to mention what that behavior is directly.

      Note: Branch closures should just return <code>null</code>. The return
      value of the <code>parallel</code> step should be ignored; See JENKINS-26033.

@bitwiseman @jglick @dwnusbaum
Apply suggestions from code review
2a6af3e 
Co-authored-by: Jesse Glick <[email protected]>
Co-authored-by: Devin Nusbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jglick jglick jglick approved these changes

@dwnusbaum dwnusbaum dwnusbaum requested changes

@rsandell rsandell Awaiting requested review from rsandell

@joseblas joseblas Awaiting requested review from joseblas

@svanoort svanoort Awaiting requested review from svanoort

@abayer abayer Awaiting requested review from abayer

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ringerc @bitwiseman @nickoe @jglick @dwnusbaum